From 829fa28a72e6f03b8ee4663281aa7475da4ef159 Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Thu, 18 Sep 2025 06:41:11 +0000 Subject: [PATCH] cephfs-journal-tool:: Don't reset the journal trim position If the fs had to go through journal recovery and reset, the cephfs-journal-tool resets the journal trim position because of which the old unused journal objects just stay forever in the metadata pool. The patch fixes the issue. Now, the old stale journal objects are trimmed during the regular trimming cycle helping to recover space in the metadata pool. Fixes: https://tracker.ceph.com/issues/69708 Signed-off-by: Kotresh HR (cherry picked from commit 4f9a926a467c03a410e5ec5a81031e72f2193f25) --- src/tools/cephfs/Resetter.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tools/cephfs/Resetter.cc b/src/tools/cephfs/Resetter.cc index 151a2e22e44..5f8c4bf121d 100644 --- a/src/tools/cephfs/Resetter.cc +++ b/src/tools/cephfs/Resetter.cc @@ -117,7 +117,6 @@ int Resetter::reset() journaler.set_read_pos(new_start); journaler.set_write_pos(new_start); journaler.set_expire_pos(new_start); - journaler.set_trimmed_pos(new_start); journaler.set_writeable(); cout << "writing journal head" << std::endl; -- 2.39.5