From 82ec00ddf082b80b871f992c279a36149129f055 Mon Sep 17 00:00:00 2001 From: Vallari Agrawal Date: Mon, 17 Mar 2025 21:58:19 +0530 Subject: [PATCH] monitoring: rename NVMeoFSingleGatewayGroup alert Rename the alert to NVMeoFSingleGateway. The original name was confusing because it accidently might convey that alert would be triggered if there is a single gateway group. Though 'NVMeoFSingleGatewayGroup' alert means that there is single gateway in a group. Signed-off-by: Vallari Agrawal --- monitoring/ceph-mixin/prometheus_alerts.libsonnet | 2 +- monitoring/ceph-mixin/prometheus_alerts.yml | 2 +- monitoring/ceph-mixin/tests_alerts/test_alerts.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitoring/ceph-mixin/prometheus_alerts.libsonnet b/monitoring/ceph-mixin/prometheus_alerts.libsonnet index f3e06a76f1f..8fef15e6a16 100644 --- a/monitoring/ceph-mixin/prometheus_alerts.libsonnet +++ b/monitoring/ceph-mixin/prometheus_alerts.libsonnet @@ -896,7 +896,7 @@ }, }, { - alert: 'NVMeoFSingleGatewayGroup', + alert: 'NVMeoFSingleGateway', 'for': '5m', expr: 'count(ceph_nvmeof_gateway_info) by(cluster,group) == 1', labels: { severity: 'warning', type: 'ceph_default' }, diff --git a/monitoring/ceph-mixin/prometheus_alerts.yml b/monitoring/ceph-mixin/prometheus_alerts.yml index f8bcd4ca0e1..599f819f544 100644 --- a/monitoring/ceph-mixin/prometheus_alerts.yml +++ b/monitoring/ceph-mixin/prometheus_alerts.yml @@ -801,7 +801,7 @@ groups: labels: severity: "warning" type: "ceph_default" - - alert: "NVMeoFSingleGatewayGroup" + - alert: "NVMeoFSingleGateway" annotations: description: "Although a single member gateway group is valid, it should only be used for test purposes" summary: "The gateway group {{ $labels.group }} consists of a single gateway - HA is not possible on cluster {{ $labels.cluster }}" diff --git a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml index 7c15798c47d..69e7b3a4b9c 100644 --- a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml +++ b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml @@ -2482,7 +2482,7 @@ tests: summary: "Max gateway groups exceeded on cluster mycluster" description: "You may create many gateway groups, but 4 is the tested limit" - # NVMeoFSingleGatewayGroup + # NVMeoFSingleGateway - interval: 1m input_series: - series: 'ceph_nvmeof_gateway_info{group="group-1",addr="1.1.1.2",cluster="mycluster"}' @@ -2499,7 +2499,7 @@ tests: value: 1 alert_rule_test: - eval_time: 5m - alertname: NVMeoFSingleGatewayGroup + alertname: NVMeoFSingleGateway exp_alerts: - exp_labels: group: group-1 -- 2.39.5