From 83d6a4e8dd57edc8a6e94e40ae6b476343fdb912 Mon Sep 17 00:00:00 2001 From: Adam Kupczyk Date: Wed, 22 May 2024 18:01:16 +0200 Subject: [PATCH] os/bluestore: Cleanup on bluestore_blob_t::release_extents Result of ongoing review. Signed-off-by: Adam Kupczyk --- src/os/bluestore/bluestore_types.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/os/bluestore/bluestore_types.cc b/src/os/bluestore/bluestore_types.cc index c8548b0d72795..e70ac5edccf69 100644 --- a/src/os/bluestore/bluestore_types.cc +++ b/src/os/bluestore/bluestore_types.cc @@ -1262,12 +1262,11 @@ uint32_t bluestore_blob_t::release_extents( // and insert hold in this place int32_t insert_element_cnt = hold_size - (p - anchor); auto anchor_it = extents.begin() + (anchor - begin); - if (insert_element_cnt != 0) { - if (insert_element_cnt > 0) { - anchor_it = extents.insert(anchor_it, insert_element_cnt, bluestore_pextent_t(0, 0)); - } else { - anchor_it = extents.erase(anchor_it, anchor_it + (-insert_element_cnt)); - } + if (insert_element_cnt > 0) { + anchor_it = extents.insert(anchor_it, insert_element_cnt, bluestore_pextent_t(0, 0)); + } + if (insert_element_cnt < 0) { + anchor_it = extents.erase(anchor_it, anchor_it + (-insert_element_cnt)); } for (uint32_t i = 0; i < hold_size; i++) { anchor_it->offset = hold[i].offset; -- 2.39.5