From 83e64fad875980844515995acee6ef501c6c7cb5 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 15 Jul 2016 16:38:23 +0800 Subject: [PATCH] test: run_seed_to_range.sh: check existance of a directory using [ -d "$dir" ] MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit sadly, sh evalutes `[ -d ]` to true. as it takes "-d" as a non-empty string as true. this fixes following failure ``` 2016-07-12T23:22:02.839 INFO:teuthology.orchestra.run.mira084.stderr:cp: missing destination file operand after ‘.’ 2016-07-12T23:22:02.839 INFO:teuthology.orchestra.run.mira084.stderr:Try 'cp --help' for more information. ``` see http://pulpito.ceph.com/kchai-2016-07-12_23:09:35-rados-wip-kefu-testing2---basic-mira/311334/ Signed-off-by: Kefu Chai --- src/test/objectstore/run_seed_to_range.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/objectstore/run_seed_to_range.sh b/src/test/objectstore/run_seed_to_range.sh index 365b34918d27..bc4e3464c4b6 100755 --- a/src/test/objectstore/run_seed_to_range.sh +++ b/src/test/objectstore/run_seed_to_range.sh @@ -12,7 +12,7 @@ mydir=`dirname $0` for f in `seq $from $to` do if ! $mydir/run_seed_to.sh $seed $f; then - if [ -d $dir ]; then + if [ -d "$dir" ]; then echo copying evidence to $dir cp -a . $dir else -- 2.47.3