From 845d21505713b8c1f48fb530d225e47a4c76f842 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Tue, 12 Oct 2021 14:30:28 -0400 Subject: [PATCH] rgw: raise log level of http client headers these messages are especially spammy because the http client's dout prefix includes the entire request path: 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:HTTP/1.1 501 Not Implemented 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:Content-Length: 108 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:x-amz-request-id: tx00000000000000027e9ba-00616514d3-70a3-east 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:Accept-Ranges: bytes 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:Content-Type: application/json 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]received header:Date: Tue, 12 Oct 2021 04:53:39 GMT 2021-10-12T04:53:39.281+0000 7f66a0ff9700 10 http_client[POST/http://example.com/admin/log?type=data¬ify2&source-zone=3a571642-9f5e-46d8-8186-9eca8cc79ac6&rgwx-zonegroup=8f3b29b1-ffc6-4c90-9d0c-9bd258028cd8]receive_http_header raise to 30 so they're only enabled for super-verbose logging Signed-off-by: Casey Bodley --- src/rgw/rgw_rest_client.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rgw/rgw_rest_client.cc b/src/rgw/rgw_rest_client.cc index 54d185516eda7..68b40324ce268 100644 --- a/src/rgw/rgw_rest_client.cc +++ b/src/rgw/rgw_rest_client.cc @@ -49,7 +49,7 @@ int RGWHTTPSimpleRequest::receive_header(void *ptr, size_t len) char *s = (char *)ptr, *end = (char *)ptr + len; char *p = line; - ldpp_dout(this, 10) << "receive_http_header" << dendl; + ldpp_dout(this, 30) << "receive_http_header" << dendl; while (s != end) { if (*s == '\r') { @@ -58,7 +58,7 @@ int RGWHTTPSimpleRequest::receive_header(void *ptr, size_t len) } if (*s == '\n') { *p = '\0'; - ldpp_dout(this, 10) << "received header:" << line << dendl; + ldpp_dout(this, 30) << "received header:" << line << dendl; // TODO: fill whatever data required here char *l = line; char *tok = strsep(&l, " \t:"); -- 2.39.5