From 84b4c5ed582634b88306121bc9e799ed20db3c4c Mon Sep 17 00:00:00 2001
From: John Mulligan <jmulligan@redhat.com>
Date: Wed, 5 Oct 2022 10:35:08 -0400
Subject: [PATCH] cephadm: add test coverage for HAproxy class

Fixes: https://tracker.ceph.com/issues/57621

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---
 src/cephadm/tests/test_ingress.py | 172 ++++++++++++++++++++++++++++++
 1 file changed, 172 insertions(+)
 create mode 100644 src/cephadm/tests/test_ingress.py

diff --git a/src/cephadm/tests/test_ingress.py b/src/cephadm/tests/test_ingress.py
new file mode 100644
index 00000000000..a1ddcfb8775
--- /dev/null
+++ b/src/cephadm/tests/test_ingress.py
@@ -0,0 +1,172 @@
+from unittest import mock
+import json
+
+import pytest
+
+from tests.fixtures import with_cephadm_ctx, cephadm_fs, import_cephadm
+
+_cephadm = import_cephadm()
+
+SAMPLE_UUID = "2d018a3f-8a8f-4cb9-a7cf-48bebb2cbaae"
+SAMPLE_HAPROXY_IMAGE = "registry.example.net/haproxy/haproxy:latest"
+
+
+def good_haproxy_json():
+    return haproxy_json(files=True)
+
+
+def haproxy_json(**kwargs):
+    if kwargs.get("files"):
+        return {
+            "files": {
+                "haproxy.cfg": "",
+            },
+        }
+    return {}
+
+
+@pytest.mark.parametrize(
+    "args",
+    # args: <fsid>, <daemon_id>, <config_json>, <image>
+    [
+        # fail due to: invalid fsid
+        (["foobar", "wilma", good_haproxy_json(), SAMPLE_HAPROXY_IMAGE]),
+        # fail due to: invalid daemon_id
+        ([SAMPLE_UUID, "", good_haproxy_json(), SAMPLE_HAPROXY_IMAGE]),
+        # fail due to: invalid image
+        ([SAMPLE_UUID, "wilma", good_haproxy_json(), ""]),
+        # fail due to: no files in config_json
+        (
+            [
+                SAMPLE_UUID,
+                "wilma",
+                haproxy_json(files=False),
+                SAMPLE_HAPROXY_IMAGE,
+            ]
+        ),
+    ],
+)
+def test_haproxy_validation_errors(args):
+    with pytest.raises(_cephadm.Error):
+        with with_cephadm_ctx([]) as ctx:
+            _cephadm.HAproxy(ctx, *args)
+
+
+def test_haproxy_init():
+    with with_cephadm_ctx([]) as ctx:
+        ctx.config_json = json.dumps(good_haproxy_json())
+        ctx.image = SAMPLE_HAPROXY_IMAGE
+        hap = _cephadm.HAproxy.init(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+        )
+    assert hap.fsid == SAMPLE_UUID
+    assert hap.daemon_id == "wilma"
+    assert hap.image == SAMPLE_HAPROXY_IMAGE
+
+
+def test_haproxy_container_mounts():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        cmounts = hap.get_container_mounts("/var/tmp")
+        assert len(cmounts) == 1
+        assert cmounts["/var/tmp/haproxy"] == "/var/lib/haproxy"
+
+
+def test_haproxy_get_daemon_name():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        assert hap.get_daemon_name() == "haproxy.wilma"
+
+
+def test_haproxy_get_container_name():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        name1 = hap.get_container_name()
+        assert (
+            name1 == "ceph-2d018a3f-8a8f-4cb9-a7cf-48bebb2cbaae-haproxy.wilma"
+        )
+        name2 = hap.get_container_name(desc="extra")
+        assert (
+            name2
+            == "ceph-2d018a3f-8a8f-4cb9-a7cf-48bebb2cbaae-haproxy.wilma-extra"
+        )
+
+
+def test_haproxy_get_daemon_args():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        args = hap.get_daemon_args()
+        assert args == ["haproxy", "-f", "/var/lib/haproxy/haproxy.cfg"]
+
+
+@mock.patch("cephadm.logger")
+def test_haproxy_create_daemon_dirs(_logger, cephadm_fs):
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        with pytest.raises(OSError):
+            hap.create_daemon_dirs("/var/tmp", 45, 54)
+        cephadm_fs.create_dir("/var/tmp")
+        hap.create_daemon_dirs("/var/tmp", 45, 54)
+        # TODO: make assertions about the dirs created
+
+
+def test_haproxy_extract_uid_gid_haproxy():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        with mock.patch("cephadm.CephContainer") as cc:
+            cc.return_value.run.return_value = "500 500"
+            uid, gid = hap.extract_uid_gid_haproxy()
+            cc.return_value.run.assert_called()
+        assert uid == 500
+        assert gid == 500
+
+
+def test_haproxy_get_sysctl_settings():
+    with with_cephadm_ctx([]) as ctx:
+        hap = _cephadm.HAproxy(
+            ctx,
+            SAMPLE_UUID,
+            "wilma",
+            good_haproxy_json(),
+            SAMPLE_HAPROXY_IMAGE,
+        )
+        ss = hap.get_sysctl_settings()
+        assert len(ss) == 3
-- 
2.39.5