From 86e9b6887f9472cea68b4caf511d8c5b1f4afc74 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 9 Sep 2020 10:17:28 +0800 Subject: [PATCH] crimson/net: do not print non-void* pointer to address the failure like fmt/core.h:902:19: error: static assertion failed: formatting of non-void pointers is disallowed 902 | static_assert(!sizeof(T), "formatting of non-void pointers is disallowed"); | ^~~~~~~~~~ and i searched around, couldn't find any other statement printing the address of message, so i think it's not of much use to print their addresses in a single place, unless we can cross check them in different places. Signed-off-by: Kefu Chai --- src/crimson/net/ProtocolV2.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crimson/net/ProtocolV2.cc b/src/crimson/net/ProtocolV2.cc index fd9567be994..750f458bd9d 100644 --- a/src/crimson/net/ProtocolV2.cc +++ b/src/crimson/net/ProtocolV2.cc @@ -1908,8 +1908,8 @@ seastar::future<> ProtocolV2::read_message(utime_t throttle_stamp) // elsewhere. in that case it doesn't matter if we "got" it or not. uint64_t cur_seq = conn.in_seq; if (message->get_seq() <= cur_seq) { - logger().error("{} got old message {} <= {} {} {}, discarding", - conn, message->get_seq(), cur_seq, message, *message); + logger().error("{} got old message {} <= {} {}, discarding", + conn, message->get_seq(), cur_seq, *message); if (HAVE_FEATURE(conn.features, RECONNECT_SEQ) && local_conf()->ms_die_on_old_message) { ceph_assert(0 == "old msgs despite reconnect_seq feature"); -- 2.39.5