From 87df05aaa4028352f1705d8fb3a2daee3a47caf1 Mon Sep 17 00:00:00 2001 From: Yuval Lifshitz Date: Thu, 19 Dec 2024 13:50:06 +0000 Subject: [PATCH] rgw/logging: test log bucket encryption error Signed-off-by: Yuval Lifshitz --- s3tests_boto3/functional/test_s3.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/s3tests_boto3/functional/test_s3.py b/s3tests_boto3/functional/test_s3.py index caadb184..8c450db8 100644 --- a/s3tests_boto3/functional/test_s3.py +++ b/s3tests_boto3/functional/test_s3.py @@ -14543,16 +14543,17 @@ def test_put_bucket_logging_errors(): except ClientError as e: assert e.response['Error']['Code'] == 'InvalidArgument' - # TODO: log bucket is encrypted - #_put_bucket_encryption_s3(client, log_bucket_name) - #try: - # response = client.put_bucket_logging(Bucket=src_bucket_name, BucketLoggingStatus={ - # 'LoggingEnabled': {'TargetBucket': log_bucket_name, 'TargetPrefix': 'log/'}, - # }) - # assert False, 'expected failure' - #except ClientError as e: - # assert e.response['Error']['Code'] == 'InvalidArgument' + # log bucket is encrypted + _put_bucket_encryption_s3(client, log_bucket_name1) + try: + response = client.put_bucket_logging(Bucket=src_bucket_name, BucketLoggingStatus={ + 'LoggingEnabled': {'TargetBucket': log_bucket_name1, 'TargetPrefix': 'log/'}, + }) + assert False, 'expected failure' + except ClientError as e: + assert e.response['Error']['Code'] == 'InvalidArgument' + # invalid log type if _has_bucket_logging_extension(): try: response = client.put_bucket_logging(Bucket=src_bucket_name, BucketLoggingStatus={ -- 2.39.5