From 881056fa9d5ae4509c3dc1b5016a92233c744753 Mon Sep 17 00:00:00 2001 From: Guillaume Abrioux Date: Wed, 20 Nov 2019 11:02:49 +0100 Subject: [PATCH] facts: avoid duplicated element in devices list When using `osd_auto_discovery`, `devices` is built multiple times due to multiple runs of `ceph-facts` role. It end up with duplicate instances of a same device in the list. Using `unique` filter when building the list fixes this issue. Signed-off-by: Guillaume Abrioux (cherry picked from commit 23b1f43897db0a03ef94f51e83ed3c562c4584d0) --- roles/ceph-facts/tasks/facts.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/ceph-facts/tasks/facts.yml b/roles/ceph-facts/tasks/facts.yml index b8da62b50..9235b9f6a 100644 --- a/roles/ceph-facts/tasks/facts.yml +++ b/roles/ceph-facts/tasks/facts.yml @@ -184,7 +184,7 @@ - name: set_fact devices generate device list when osd_auto_discovery set_fact: - devices: "{{ devices | default([]) + [ item.key | regex_replace('^', '/dev/') ] }}" + devices: "{{ (devices | default([]) + [ item.key | regex_replace('^', '/dev/') ]) | unique }}" with_dict: "{{ ansible_devices }}" when: - osd_auto_discovery|default(False) -- 2.47.3