From 895a76a4fe018fab584efbdbc54a0e084a3d89af Mon Sep 17 00:00:00 2001 From: xie xingguo Date: Wed, 28 Sep 2016 15:50:23 +0800 Subject: [PATCH] os/bluestore: add a counter to trace rejected compress ops This is useful for choosing a more proper bluestore_compression_required_ratio. Signed-off-by: xie xingguo --- src/os/bluestore/BlueStore.cc | 4 +++- src/os/bluestore/BlueStore.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc index cd73bef1eedc..4b211e14306d 100644 --- a/src/os/bluestore/BlueStore.cc +++ b/src/os/bluestore/BlueStore.cc @@ -2346,7 +2346,8 @@ void BlueStore::_init_logger() "Average checksum latency"); b.add_u64(l_bluestore_compress_success_count, "compress_success_count", "Sum for beneficial compress ops"); - + b.add_u64(l_bluestore_compress_rejected_count, "compress_rejected_count", + "Sum for compress ops rejected due to low net gain of space"); b.add_u64(l_bluestore_write_pad_bytes, "write_pad_bytes", "Sum for write-op padded bytes"); b.add_u64(l_bluestore_wal_write_ops, "wal_write_ops", @@ -7295,6 +7296,7 @@ int BlueStore::_do_alloc_write( << ", which is more than required 0x" << dstlen << ", leaving uncompressed" << std::dec << dendl; + logger->inc(l_bluestore_compress_rejected_count); } logger->tinc(l_bluestore_compress_lat, ceph_clock_now(g_ceph_context) - start); } diff --git a/src/os/bluestore/BlueStore.h b/src/os/bluestore/BlueStore.h index 00818a3b522c..0d996c3bf095 100644 --- a/src/os/bluestore/BlueStore.h +++ b/src/os/bluestore/BlueStore.h @@ -62,6 +62,7 @@ enum { l_bluestore_decompress_lat, l_bluestore_csum_lat, l_bluestore_compress_success_count, + l_bluestore_compress_rejected_count, l_bluestore_write_pad_bytes, l_bluestore_wal_write_ops, l_bluestore_wal_write_bytes, -- 2.47.3