From 8a8bd9bd82248c7946f1ab3ab7aaa9cb41f468fc Mon Sep 17 00:00:00 2001 From: Kyr Shatskyy Date: Wed, 10 Oct 2018 10:08:11 +0200 Subject: [PATCH] tests: use dict() instead Mock() to test config Addresses failure in verify_package_version: TypeError: argument of type 'Mock' is not iterable Signed-off-by: Kyr Shatskyy --- teuthology/test/task/test_install.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/teuthology/test/task/test_install.py b/teuthology/test/task/test_install.py index 945c3375f..5cf7e2d55 100644 --- a/teuthology/test/task/test_install.py +++ b/teuthology/test/task/test_install.py @@ -78,7 +78,8 @@ class TestInstall(object): gb.project = "ceph" m_gitbuilder_project.return_value = gb m_get_package_version.return_value = "0.89.0" - install.verify_package_version(Mock(), Mock(), Mock()) + config = dict() + install.verify_package_version(Mock(), config, Mock()) @patch("teuthology.task.install._get_builder_project") @patch("teuthology.task.install.packaging.get_package_version") @@ -89,9 +90,7 @@ class TestInstall(object): gb.project = "ceph" m_gitbuilder_project.return_value = gb m_get_package_version.return_value = "0.89.1" - config = Mock() - # when it looks for config.get('extras') it won't find it - config.get.return_value = False + config = dict() with pytest.raises(RuntimeError): install.verify_package_version(Mock(), config, Mock()) @@ -105,8 +104,8 @@ class TestInstall(object): m_gitbuilder_project.return_value = gb # ceph isn't installed because ceph-deploy would install it m_get_package_version.return_value = None - config = Mock() - config.extras = True + config = dict() + config['extras'] = True install.verify_package_version(Mock(), config, Mock()) def test_get_flavor_default(self): -- 2.47.3