From 8b41a8a517f71323c69432c88fe8092dbbf521a2 Mon Sep 17 00:00:00 2001 From: Zack Cerza Date: Wed, 25 Jul 2018 16:18:36 -0600 Subject: [PATCH] Revert "[DNM] upgrade check: upgrade to same version is a noop" --- teuthology/task/install/__init__.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/teuthology/task/install/__init__.py b/teuthology/task/install/__init__.py index 9218329db0..458b2c2b84 100644 --- a/teuthology/task/install/__init__.py +++ b/teuthology/task/install/__init__.py @@ -339,11 +339,6 @@ def upgrade_remote_to_config(ctx, config): return result -def _upgrade_is_noop(installed_version, upgrade_version): - assert installed_version, "installed_version is empty" - assert upgrade_version, "upgrade_version is empty" - return LooseVersion(installed_version) == LooseVersion(upgrade_version) - def _upgrade_is_downgrade(installed_version, upgrade_version): assert installed_version, "installed_version is empty" assert upgrade_version, "upgrade_version is empty" @@ -377,11 +372,6 @@ def upgrade_common(ctx, config, deploy_style): i=installed_version, u=upgrade_version )) - if _upgrade_is_noop(installed_version, upgrade_version): - raise RuntimeError( - "Upgrade to the same version as is already installed is a " - " NOOP. Hint: check the test yaml." - ) if _upgrade_is_downgrade(installed_version, upgrade_version): raise RuntimeError( "An attempt to upgrade from a higher version to a lower one " -- 2.39.5