From 8bbafd2859d77875d8ef1457d6604dfce3f8fb3c Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 9 May 2017 12:56:59 +0800 Subject: [PATCH] libradosstriper: do not assign garbage to returned value if `rc` is not zero, the returned `ssize` is either garbage or undefined. this silences warning from clang analyzer: Assigned value is garbage or undefined Signed-off-by: Kefu Chai --- src/libradosstriper/RadosStriperImpl.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libradosstriper/RadosStriperImpl.cc b/src/libradosstriper/RadosStriperImpl.cc index ea3be3b145c69..47c36fd3aa62c 100644 --- a/src/libradosstriper/RadosStriperImpl.cc +++ b/src/libradosstriper/RadosStriperImpl.cc @@ -1169,10 +1169,13 @@ int libradosstriper::RadosStriperImpl::internal_get_layout_and_size( // deal with size size_t ssize; rc = extract_sizet_attr(attrs, XATTR_SIZE, &ssize); + if (rc) { + return rc; + } *size = ssize; // make valgrind happy by setting unused fl_pg_pool layout->fl_pg_pool = 0; - return rc; + return 0; } int libradosstriper::RadosStriperImpl::openStripedObjectForRead( -- 2.39.5