From 8d4ef76923cdf3edec2cdeb9a8bdad6d545429f4 Mon Sep 17 00:00:00 2001 From: Rishabh Dave Date: Mon, 25 Apr 2022 13:18:47 +0530 Subject: [PATCH] qa/vstart_runner.py: add a note about omitting sudo About the commit date: this commit got dropped from the patch series during some PR branch update but is added back now. Signed-off-by: Rishabh Dave --- qa/tasks/vstart_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py index 2fa8bbe6be3..341fb036a3c 100644 --- a/qa/tasks/vstart_runner.py +++ b/qa/tasks/vstart_runner.py @@ -425,6 +425,8 @@ ceph-coverage() { # We'll let sudo be a part of command even omit flag says otherwise in # cases of commands which can normally be ran only by root. last_arg = args[args.rfind(' ') + 1 : ] + # XXX: should sudo be omitted/allowed by default in cases similar to + # that of "exec sudo" as well? if 'sudo' in args: for x in ('passwd', 'chown'): if x == first_arg or x == last_arg or f' {x} ' in args: -- 2.39.5