From 8dc4fbc19bc03ec36d992dcf75bdf62b33a0b645 Mon Sep 17 00:00:00 2001 From: Aishwarya Mathuria Date: Wed, 21 Jan 2026 11:00:17 +0000 Subject: [PATCH] src/crimson/osd/pg: Add DEBUG logging to do_delete_work Signed-off-by: Aishwarya Mathuria --- src/crimson/osd/pg.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc index d327aefaa92..59f5ff7c764 100644 --- a/src/crimson/osd/pg.cc +++ b/src/crimson/osd/pg.cc @@ -480,7 +480,8 @@ void PG::prepare_write(pg_info_t &info, std::pair PG::do_delete_work(ceph::os::Transaction &t, ghobject_t _next) { - logger().info("removing pg {}", pgid); + LOG_PREFIX(PG::do_delete_work); + DEBUGDPP("removing pg {}", *this, pgid); auto fut = interruptor::make_interruptible( shard_services.get_store().list_objects( coll_ref, @@ -490,7 +491,7 @@ PG::do_delete_work(ceph::os::Transaction &t, ghobject_t _next) auto [objs_to_rm, next] = fut.get(); if (objs_to_rm.empty()) { - logger().info("all objs removed, removing coll for {}", pgid); + DEBUGDPP("all objs removed, removing coll for {}", *this, pgid); t.remove(coll_ref->get_cid(), pgid.make_snapmapper_oid()); t.remove(coll_ref->get_cid(), pgmeta_oid); t.remove_collection(coll_ref->get_cid()); @@ -500,17 +501,19 @@ PG::do_delete_work(ceph::os::Transaction &t, ghobject_t _next) }); return {next, false}; } else { + DEBUGDPP("pg {}, removing {} objects in this batch", + *this, pgid, objs_to_rm.size()); for (auto &obj : objs_to_rm) { if (obj == pgmeta_oid || obj.is_internal_pg_local()) { continue; } - logger().trace("pg {}, removing obj {}", pgid, obj); + TRACEDPP("pg {}, removing obj {}", *this, pgid, obj); t.remove(coll_ref->get_cid(), obj); } t.register_on_commit( - new LambdaContext([this](int r) { + new LambdaContext([this, FNAME](int r) { ceph_assert(r == 0); - logger().trace("triggering more pg delete {}", pgid); + DEBUGDPP("triggering more pg delete {}", *this, pgid); (void) shard_services.start_operation( this, pg_whoami, -- 2.47.3