From 8f2de92712a98568b0d07a795f1158868caae550 Mon Sep 17 00:00:00 2001 From: Venky Shankar Date: Mon, 6 Aug 2018 03:20:35 -0400 Subject: [PATCH] mds: add counter for tracking cap non-responding clients Signed-off-by: Venky Shankar --- src/mds/Server.cc | 10 ++++++++-- src/mds/Server.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mds/Server.cc b/src/mds/Server.cc index 21e59f263f998..27252fa8364a3 100644 --- a/src/mds/Server.cc +++ b/src/mds/Server.cc @@ -107,6 +107,8 @@ void Server::create_logger() plb.add_u64_counter(l_mdss_handle_client_session, "handle_client_session", "Client session messages", "hcs", PerfCountersBuilder::PRIO_INTERESTING); + plb.add_u64_counter(l_mdss_cap_revoke_eviction, "cap_revoke_eviction", + "Cap Revoke Client Eviction", "cre", PerfCountersBuilder::PRIO_INTERESTING); // fop latencies are useful plb.set_prio_default(PerfCountersBuilder::PRIO_USEFUL); @@ -842,8 +844,12 @@ void Server::evict_cap_revoke_non_responders() { << client << dendl; std::stringstream ss; - mds->evict_client(client.v, false, g_conf()->mds_session_blacklist_on_evict, - ss, nullptr); + bool evicted = mds->evict_client(client.v, false, + g_conf()->mds_session_blacklist_on_evict, + ss, nullptr); + if (evicted && logger) { + logger->inc(l_mdss_cap_revoke_eviction); + } } } diff --git a/src/mds/Server.h b/src/mds/Server.h index 36bbbbbe51c10..44521d7477dec 100644 --- a/src/mds/Server.h +++ b/src/mds/Server.h @@ -71,6 +71,7 @@ enum { l_mdss_req_setxattr_latency, l_mdss_req_symlink_latency, l_mdss_req_unlink_latency, + l_mdss_cap_revoke_eviction, l_mdss_last, }; -- 2.39.5