From 8f75db34bd87072cdb6e7ea4b33b0e54b6012b29 Mon Sep 17 00:00:00 2001
From: Greg Farnum <greg@inktank.com>
Date: Sun, 3 Feb 2013 21:12:26 -0800
Subject: [PATCH] mds: ETableServer more modernization for dencoder

Signed-off-by: Greg Farnum <greg@inktank.com>
---
 src/mds/events/ETableServer.h | 32 +++++-------------------
 src/mds/journal.cc            | 46 +++++++++++++++++++++++++++++++++++
 src/test/encoding/types.h     |  2 ++
 3 files changed, 54 insertions(+), 26 deletions(-)

diff --git a/src/mds/events/ETableServer.h b/src/mds/events/ETableServer.h
index d66dff7117261..ee63e47a41624 100644
--- a/src/mds/events/ETableServer.h
+++ b/src/mds/events/ETableServer.h
@@ -30,36 +30,16 @@ struct ETableServer : public LogEvent {
   version_t tid;
   version_t version;
 
-  ETableServer() : LogEvent(EVENT_TABLESERVER) { }
+  ETableServer() : LogEvent(EVENT_TABLESERVER), table(0), op(0),
+		   reqid(0), bymds(0), tid(0), version(0) { }
   ETableServer(int t, int o, uint64_t ri, int m, version_t ti, version_t v) :
     LogEvent(EVENT_TABLESERVER),
     table(t), op(o), reqid(ri), bymds(m), tid(ti), version(v) { }
 
-  void encode(bufferlist& bl) const {
-    ENCODE_START(3, 3, bl);
-    ::encode(stamp, bl);
-    ::encode(table, bl);
-    ::encode(op, bl);
-    ::encode(reqid, bl);
-    ::encode(bymds, bl);
-    ::encode(mutation, bl);
-    ::encode(tid, bl);
-    ::encode(version, bl);
-    ENCODE_FINISH(bl);
-  }
-  void decode(bufferlist::iterator &bl) {
-    DECODE_START_LEGACY_COMPAT_LEN(3, 3, 3, bl);
-    if (struct_v >= 2)
-      ::decode(stamp, bl);
-    ::decode(table, bl);
-    ::decode(op, bl);
-    ::decode(reqid, bl);
-    ::decode(bymds, bl);
-    ::decode(mutation, bl);
-    ::decode(tid, bl);
-    ::decode(version, bl);
-    DECODE_FINISH(bl);
-  }
+  void encode(bufferlist& bl) const;
+  void decode(bufferlist::iterator& bl);
+  void dump(Formatter *f) const;
+  static void generate_test_instances(list<ETableServer*>& ls);
 
   void print(ostream& out) {
     out << "ETableServer " << get_mdstable_name(table) 
diff --git a/src/mds/journal.cc b/src/mds/journal.cc
index c3ffd9f4afab3..6016edcaaffbb 100644
--- a/src/mds/journal.cc
+++ b/src/mds/journal.cc
@@ -1484,6 +1484,52 @@ void ESessions::replay(MDS *mds)
 }
 
 
+// -----------------------
+// ETableServer
+
+void ETableServer::encode(bufferlist& bl) const
+{
+  ENCODE_START(3, 3, bl);
+  ::encode(stamp, bl);
+  ::encode(table, bl);
+  ::encode(op, bl);
+  ::encode(reqid, bl);
+  ::encode(bymds, bl);
+  ::encode(mutation, bl);
+  ::encode(tid, bl);
+  ::encode(version, bl);
+  ENCODE_FINISH(bl);
+}
+
+void ETableServer::decode(bufferlist::iterator &bl)
+{
+  DECODE_START_LEGACY_COMPAT_LEN(3, 3, 3, bl);
+  if (struct_v >= 2)
+    ::decode(stamp, bl);
+  ::decode(table, bl);
+  ::decode(op, bl);
+  ::decode(reqid, bl);
+  ::decode(bymds, bl);
+  ::decode(mutation, bl);
+  ::decode(tid, bl);
+  ::decode(version, bl);
+  DECODE_FINISH(bl);
+}
+
+void ETableServer::dump(Formatter *f) const
+{
+  f->dump_int("table id", table);
+  f->dump_int("op", op);
+  f->dump_int("request id", reqid);
+  f->dump_int("by mds", bymds);
+  f->dump_int("tid", tid);
+  f->dump_int("version", version);
+}
+
+void ETableServer::generate_test_instances(list<ETableServer*>& ls)
+{
+  ls.push_back(new ETableServer());
+}
 
 
 void ETableServer::update_segment()
diff --git a/src/test/encoding/types.h b/src/test/encoding/types.h
index 2f788fdea491e..311b89eab1450 100644
--- a/src/test/encoding/types.h
+++ b/src/test/encoding/types.h
@@ -157,6 +157,8 @@ TYPE(ESlaveUpdate)
 TYPE(ESubtreeMap)
 #include "mds/events/ETableClient.h"
 TYPE(ETableClient)
+#include "mds/events/ETableServer.h"
+TYPE(ETableServer)
 
 #ifdef WITH_RADOSGW
 
-- 
2.39.5