From 8fb0481391be8eb24468f8916fd094ce7fe6ba03 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Wed, 9 Jan 2013 16:41:40 -0800 Subject: [PATCH] ReplicatedPG: compare nlinks to snapcolls nlinks gives us the number of hardlinks to the object. nlinks should be 1 + snapcolls.size(). This will allow us to detect links which remain in an erroneous snap collection. Signed-off-by: Samuel Just --- src/osd/ReplicatedPG.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc index f0fd24e4640b0..8b24fc93b9673 100644 --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -6672,6 +6672,12 @@ bool ReplicatedPG::_report_snap_collection_errors( << std::endl; errors = true; } + if (nlinks != snapcolls.size() + 1) { + out << info.pgid << " osd." << osd << " unaccounted for links on object " + << hoid << " snapcolls " << snapcolls << " nlinks " << nlinks + << std::endl; + errors = true; + } return errors; } -- 2.39.5