From 916faf07f20f52865eab48887a088ccdb8361ff8 Mon Sep 17 00:00:00 2001 From: Jinyong Ha Date: Mon, 24 May 2021 18:37:37 +0900 Subject: [PATCH] seastore: utilize unique_ptr as a return value of create() Signed-off-by: Jinyong Ha --- src/crimson/os/seastore/nvmedevice/nvmedevice.h | 4 ++-- src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/crimson/os/seastore/nvmedevice/nvmedevice.h b/src/crimson/os/seastore/nvmedevice/nvmedevice.h index ee8965a6fe3..c13ec796fc7 100644 --- a/src/crimson/os/seastore/nvmedevice/nvmedevice.h +++ b/src/crimson/os/seastore/nvmedevice/nvmedevice.h @@ -154,8 +154,8 @@ public: virtual ~NVMeBlockDevice() = default; template - static NVMeBlockDevice *create() { - return new T(); + static std::unique_ptr create() { + return std::make_unique(); } /* diff --git a/src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc b/src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc index 1d79a01ec0c..7dfaece9ef7 100644 --- a/src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc +++ b/src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc @@ -12,7 +12,7 @@ using namespace crimson::os::seastore; using namespace nvme_device; struct nvdev_test_t : seastar_test_suite_t { - NVMeBlockDevice* device; + std::unique_ptr device; std::string dev_path; static const uint64_t DEV_SIZE = 1024 * 1024 * 1024; -- 2.47.3