From 91b2a2b69b198567d42f45f75b7f7ea559f89150 Mon Sep 17 00:00:00 2001 From: Joao Eduardo Luis Date: Fri, 17 Oct 2014 18:01:05 +0100 Subject: [PATCH] mon: MDSMonitor: don't return -EINVAL if function is bool Returning -EINVAL on a function that expects bool and the error code to be in a variable 'r' can only achieve one thing: if this path is ever touched, instead of returning an error as it was supposed to, we're returning 'true' with 'r = 0' and, for no apparent reason, the user will think everything went smoothly but with no new fs created. Signed-off-by: Joao Eduardo Luis --- src/mon/MDSMonitor.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc index aa20d933a0fdd..0d32eaabe9e56 100644 --- a/src/mon/MDSMonitor.cc +++ b/src/mon/MDSMonitor.cc @@ -1092,7 +1092,8 @@ bool MDSMonitor::management_command( // Ensure fs name is not empty so that we can implement // commmands that refer to FS by name in future. ss << "Filesystem name may not be empty"; - return -EINVAL; + r = -EINVAL; + return true; } if (pending_mdsmap.get_enabled() -- 2.39.5