From 92eb6836bfb3350f11fcc2d55a4710be45a34e4f Mon Sep 17 00:00:00 2001 From: David Zafman Date: Wed, 23 Aug 2017 15:31:50 -0700 Subject: [PATCH] config: disable skewed utilization warning by default This has a few problems: 1- It does not do it's analysis over CRUSH rule roots/classes, which means that an innocent user of classes will see skewed usage (bc hdds are more full than ssds, say) 2- It does not take degraded clusters into account, which means the warning will appear when a fresh OSD is added. See http://tracker.ceph.com/issues/20730 Based on master commit 7832c53 but we've decided not to remove the code in the older releases so it can be used if appropriate for a particular cluster configuration. Also, 7832c53 won't cleanly cherry-pick so this is easier. Signed-off-by: David Zafman --- PendingReleaseNotes | 3 +++ src/common/config_opts.h | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/PendingReleaseNotes b/PendingReleaseNotes index e69de29bb2d1d..322d8b5e6395f 100644 --- a/PendingReleaseNotes +++ b/PendingReleaseNotes @@ -0,0 +1,3 @@ +* The 'mon_warn_osd_usage_min_max_delta' health warning has been disabled because + it does not address clusters undergoing recovery or CRUSH rules that do + not target all devices in the cluster. diff --git a/src/common/config_opts.h b/src/common/config_opts.h index 68f2ebe1f00bf..b8ea128dc6715 100644 --- a/src/common/config_opts.h +++ b/src/common/config_opts.h @@ -273,8 +273,7 @@ OPTION(mon_crush_min_required_version, OPT_STR, "firefly") OPTION(mon_warn_on_crush_straw_calc_version_zero, OPT_BOOL, true) // warn if crush straw_calc_version==0 OPTION(mon_warn_on_osd_down_out_interval_zero, OPT_BOOL, true) // warn if 'mon_osd_down_out_interval == 0' OPTION(mon_warn_on_cache_pools_without_hit_sets, OPT_BOOL, true) -OPTION(mon_warn_osd_usage_percent, OPT_FLOAT, .40) // warn if difference in usage percent between OSDs exceeds specified percent -OPTION(mon_warn_osd_usage_min_max_delta, OPT_FLOAT, .40) // warn if difference between min and max OSD utilizations exceeds specified amount +OPTION(mon_warn_osd_usage_min_max_delta, OPT_FLOAT, 0) // warn if difference between min and max OSD utilizations exceeds specified amount OPTION(mon_min_osdmap_epochs, OPT_INT, 500) OPTION(mon_max_pgmap_epochs, OPT_INT, 500) OPTION(mon_max_log_epochs, OPT_INT, 500) -- 2.39.5