From 93efc1e9484ea41f3eb831dcb3d19d63b044ef70 Mon Sep 17 00:00:00 2001 From: John Spray Date: Thu, 9 Mar 2017 13:15:46 +0000 Subject: [PATCH] mon: fix hiding mdsmonitor informative strings Local `stringstream ss` declarations were hiding the real variable used to feed back to the user. Fixes: http://tracker.ceph.com/issues/16709 Signed-off-by: John Spray (cherry picked from commit 00404ae9bd4cce0518a44d36d2d6a5612f4f9d04) --- src/mon/MDSMonitor.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc index 9015405ee2a9e..01243a0e3ee4e 100644 --- a/src/mon/MDSMonitor.cc +++ b/src/mon/MDSMonitor.cc @@ -2272,7 +2272,6 @@ int MDSMonitor::filesystem_command( pending_fsmap.modify_daemon(gid, [state](MDSMap::mds_info_t *info) { info->state = state; }); - stringstream ss; ss << "set mds gid " << gid << " to state " << state << " " << ceph_mds_state_name(state); return 0; @@ -2303,7 +2302,6 @@ int MDSMonitor::filesystem_command( return -EBUSY; } else { pending_fsmap.erase(gid, {}); - stringstream ss; ss << "removed mds gid " << gid; return 0; } @@ -2333,7 +2331,6 @@ int MDSMonitor::filesystem_command( fs->mds_map.failed.erase(role.rank); }); - stringstream ss; ss << "removed failed mds." << role; return 0; } else if (prefix == "mds compat rm_compat") { -- 2.39.5