From 959140e7858ea335a6bd83851d70b0e3fbeed5df Mon Sep 17 00:00:00 2001
From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Sun, 17 Jan 2021 20:17:30 +0100
Subject: [PATCH] library: move `fatal()` into ca_common.py

this function is defined in various modules, let's move it to
`ca_common.py`

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
---
 library/ceph_crush.py     | 14 ++++----------
 library/ceph_key.py       | 15 ++-------------
 library/ceph_volume.py    | 15 ++-------------
 module_utils/ca_common.py | 10 ++++++++++
 4 files changed, 18 insertions(+), 36 deletions(-)

diff --git a/library/ceph_crush.py b/library/ceph_crush.py
index 6ada0b459..7cb9688be 100644
--- a/library/ceph_crush.py
+++ b/library/ceph_crush.py
@@ -8,6 +8,10 @@ from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
 from ansible.module_utils.basic import AnsibleModule
+try:
+    from ansible.module_utils.ca_common import fatal
+except ImportError:
+    from module_utils.ca_common import fatal
 import datetime
 
 ANSIBLE_METADATA = {
@@ -62,16 +66,6 @@ EXAMPLES = '''
 RETURN = '''#  '''
 
 
-def fatal(message, module):
-    '''
-    Report a fatal error and exit
-    '''
-    if module:
-        module.fail_json(msg=message, rc=1)
-    else:
-        raise(Exception(message))
-
-
 def generate_cmd(cluster, subcommand, bucket, bucket_type, containerized=None):
     '''
     Generate command line to execute
diff --git a/library/ceph_key.py b/library/ceph_key.py
index 6b98e075c..231e93dae 100644
--- a/library/ceph_key.py
+++ b/library/ceph_key.py
@@ -19,9 +19,9 @@ __metaclass__ = type
 
 from ansible.module_utils.basic import AnsibleModule
 try:
-    from ansible.module_utils.ca_common import is_containerized, container_exec
+    from ansible.module_utils.ca_common import is_containerized, container_exec, fatal
 except ImportError:
-    from module_utils.ca_common import is_containerized, container_exec
+    from module_utils.ca_common import is_containerized, container_exec, fatal
 import datetime
 import json
 import os
@@ -219,17 +219,6 @@ def str_to_bool(val):
         raise ValueError("Invalid input value: %s" % val)
 
 
-def fatal(message, module):
-    '''
-    Report a fatal error and exit
-    '''
-
-    if module:
-        module.fail_json(msg=message, rc=1)
-    else:
-        raise(Exception(message))
-
-
 def generate_secret():
     '''
     Generate a CephX secret
diff --git a/library/ceph_volume.py b/library/ceph_volume.py
index d32325523..dd315e8b8 100644
--- a/library/ceph_volume.py
+++ b/library/ceph_volume.py
@@ -2,9 +2,9 @@
 
 from ansible.module_utils.basic import AnsibleModule
 try:
-    from ansible.module_utils.ca_common import exec_command, is_containerized
+    from ansible.module_utils.ca_common import exec_command, is_containerized, fatal
 except ImportError:
-    from module_utils.ca_common import exec_command, is_containerized
+    from module_utils.ca_common import exec_command, is_containerized, fatal
 import datetime
 import copy
 import json
@@ -186,17 +186,6 @@ EXAMPLES = '''
 '''
 
 
-def fatal(message, module):
-    '''
-    Report a fatal error and exit
-    '''
-
-    if module:
-        module.fail_json(msg=message, changed=False, rc=1)
-    else:
-        raise(Exception(message))
-
-
 def container_exec(binary, container_image):
     '''
     Build the docker CLI to run a command inside a container
diff --git a/module_utils/ca_common.py b/module_utils/ca_common.py
index 8c75c4cec..2a9d95e1e 100644
--- a/module_utils/ca_common.py
+++ b/module_utils/ca_common.py
@@ -99,3 +99,13 @@ def exit_module(module, out, rc, cmd, err, startd, changed=False):
         changed=changed,
     )
     module.exit_json(**result)
+
+def fatal(message, module):
+    '''
+    Report a fatal error and exit
+    '''
+
+    if module:
+        module.fail_json(msg=message, rc=1)
+    else:
+        raise(Exception(message))
-- 
2.39.5