From 95aa2e5ab772bd98fb2fe73d31836f865937aad7 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 1 Nov 2019 13:32:24 +0800 Subject: [PATCH] librbd: always initialize local variables silence warnings like: src/librbd/io/ImageRequestWQ.cc:576:7: warning: 'length' may be used uninitialized in this function [-Wmaybe-uninitialized] if (block_overlapping_io(&m_in_flight_extents, offset, length)) { ^~ ... src/librbd/io/ImageRequestWQ.cc:935:12: note: 'length' was declared here uint64_t length; ^~~~~~ Signed-off-by: Kefu Chai --- src/librbd/io/ImageRequestWQ.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/librbd/io/ImageRequestWQ.cc b/src/librbd/io/ImageRequestWQ.cc index 1836eb29733..2a7a0df94fa 100644 --- a/src/librbd/io/ImageRequestWQ.cc +++ b/src/librbd/io/ImageRequestWQ.cc @@ -931,8 +931,8 @@ void ImageRequestWQ::process_io(ImageDispatchSpec *req, const auto& extents = req->get_image_extents(); bool write_op = req->is_write_op(); uint64_t tid = req->get_tid(); - uint64_t offset; - uint64_t length; + uint64_t offset = 0; + uint64_t length = 0; if (write_op) { std::lock_guard locker{m_lock}; -- 2.39.5