From 978e9c88b5d8aaaee22db094e99fcbf8e61efb33 Mon Sep 17 00:00:00 2001 From: Matan Breizman Date: Tue, 24 Jun 2025 10:25:36 +0000 Subject: [PATCH] crimson/common/smp_helpers: cleanup invoke_on_all_seq Signed-off-by: Matan Breizman --- src/crimson/common/smp_helpers.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/crimson/common/smp_helpers.h b/src/crimson/common/smp_helpers.h index 435b386821b42..80d56b086ba06 100644 --- a/src/crimson/common/smp_helpers.h +++ b/src/crimson/common/smp_helpers.h @@ -21,6 +21,11 @@ namespace crimson { using core_id_t = seastar::shard_id; static constexpr core_id_t NULL_CORE = std::numeric_limits::max(); +/** + * submit_to + * + * Transparently deal with vanilla and errorated futures + */ auto submit_to(core_id_t core, auto &&f) { using ret_type = decltype(f()); if constexpr (is_errorated_future_v) { @@ -56,12 +61,7 @@ auto proxy_method_on_core( template auto invoke_on_all_seq(F f) -> decltype(seastar::futurize_invoke(f)) { for (auto core: seastar::smp::all_cpus()) { - using ret_type = decltype(f()); - if constexpr (is_errorated_future_v) { co_await crimson::submit_to(core, [&f] { return seastar::futurize_invoke(f);}); - } else { - co_await seastar::smp::submit_to(core, [&f] { return seastar::futurize_invoke(f);}); - } } } -- 2.39.5