From 97f54b081537e0ee99317927d8da850b72e4415f Mon Sep 17 00:00:00 2001 From: Tomer Haskalovitch Date: Thu, 9 Oct 2025 09:33:57 +0300 Subject: [PATCH] mgr/dashboard: change the default max namespace from 4096 to None in subsystem add command to take gw default Signed-off-by: Tomer Haskalovitch --- src/pybind/mgr/dashboard/controllers/nvmeof.py | 4 ++-- src/pybind/mgr/dashboard/openapi.yaml | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py index b8e47a0e1d0a5..6feb415ed6999 100644 --- a/src/pybind/mgr/dashboard/controllers/nvmeof.py +++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py @@ -197,7 +197,7 @@ else: parameters={ "nqn": Param(str, "NVMeoF subsystem NQN"), "enable_ha": Param(bool, "Enable high availability", True, None), - "max_namespaces": Param(int, "Maximum number of namespaces", True, 4096), + "max_namespaces": Param(int, "Maximum number of namespaces", True, None), "no_group_append": Param(int, "Do not append gateway group name to the NQN", True, False), "serial_number": Param(int, "Subsystem serial number", True, None), @@ -209,7 +209,7 @@ else: @convert_to_model(model.SubsystemStatus) @handle_nvmeof_error def create(self, nqn: str, enable_ha: Optional[bool] = True, - max_namespaces: Optional[int] = 4096, no_group_append: Optional[bool] = False, + max_namespaces: Optional[int] = None, no_group_append: Optional[bool] = False, serial_number: Optional[str] = None, dhchap_key: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None): return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.create_subsystem( diff --git a/src/pybind/mgr/dashboard/openapi.yaml b/src/pybind/mgr/dashboard/openapi.yaml index b4eec2ac97b16..55360180fa165 100755 --- a/src/pybind/mgr/dashboard/openapi.yaml +++ b/src/pybind/mgr/dashboard/openapi.yaml @@ -8800,7 +8800,6 @@ paths: description: NVMeoF gateway group type: string max_namespaces: - default: 4096 description: Maximum number of namespaces type: integer no_group_append: -- 2.39.5