From 98cca5ed5a1b14a459d1a049bd2455b47a508f89 Mon Sep 17 00:00:00 2001 From: Xiubo Li Date: Mon, 22 Nov 2021 10:33:00 +0800 Subject: [PATCH] client: fix crash when iterating and deleting sessions Introduced-by: 730dd8a87a3dbeba348dd419869ac110c57ed47a Fixes: https://tracker.ceph.com/issues/53082 Signed-off-by: Xiubo Li --- src/client/Client.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 039ede40aeb23..4e5e4164c3553 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -2866,9 +2866,10 @@ void Client::handle_mds_map(const MConstRef& m) _mdsmap.swap(mdsmap); // reset session - for (auto &p : mds_sessions) { - mds_rank_t mds = p.first; - auto session = p.second; + for (auto p = mds_sessions.begin(); p != mds_sessions.end(); ) { + mds_rank_t mds = p->first; + MetaSessionRef session = p->second; + ++p; int oldstate = _mdsmap->get_state(mds); int newstate = mdsmap->get_state(mds); -- 2.39.5