From 995ac9438c2907eac50f19f69813f4281c00d059 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 23 Nov 2016 13:31:28 +0800 Subject: [PATCH] common/blkdev: get_device_by_uuid() silence clang warning early return if blkid_get_cache() fails. this chance is but cosmetic, it pleases clang static analyzer which thinks that rc will be overwritten if dev is nullptr. Signed-off-by: Kefu Chai --- src/common/blkdev.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/blkdev.cc b/src/common/blkdev.cc index 90d6c3f923c..26f3d580d2f 100644 --- a/src/common/blkdev.cc +++ b/src/common/blkdev.cc @@ -197,7 +197,7 @@ int get_device_by_uuid(uuid_d dev_uuid, const char* label, char* partition, if (blkid_get_cache(&cache, NULL) >= 0) dev = blkid_find_dev_with_tag(cache, label, (const char*)uuid_str); else - rc = -EINVAL; + return -EINVAL; if (dev) { temp_partition_ptr = blkid_dev_devname(dev); -- 2.39.5