From 99906ea6cef747d8ab6c154ccc884cd4f3187dc2 Mon Sep 17 00:00:00 2001 From: Ramana Raja Date: Sun, 10 Apr 2022 14:18:53 -0400 Subject: [PATCH] mgr/nfs: don't output any message ... when `nfs cluster create/rm` succeeds. This also fixes the misleading output message that said NFS cluster creation or removal was complete when the `nfs cluster create/rm` command returned. The `nfs cluster create/rm` command triggers the asynchronous creation/removal of the NFS daemons and ingress service of the cluster. Fixes: https://tracker.ceph.com/issues/55299 Signed-off-by: Ramana Raja --- src/pybind/mgr/nfs/cluster.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/nfs/cluster.py b/src/pybind/mgr/nfs/cluster.py index 68980cb9cd8..4ddc750044e 100644 --- a/src/pybind/mgr/nfs/cluster.py +++ b/src/pybind/mgr/nfs/cluster.py @@ -121,7 +121,7 @@ class NFSCluster: if cluster_id not in available_clusters(self.mgr): self._call_orch_apply_nfs(cluster_id, placement, virtual_ip, port) - return 0, "NFS Cluster Created Successfully", "" + return 0, "", "" return 0, "", f"{cluster_id} cluster already exists" except Exception as e: return exception_handler(e, f"NFS Cluster {cluster_id} could not be created") @@ -136,7 +136,7 @@ class NFSCluster: completion = self.mgr.remove_service('nfs.' + cluster_id) orchestrator.raise_if_exception(completion) self.delete_config_obj(cluster_id) - return 0, "NFS Cluster Deleted Successfully", "" + return 0, "", "" return 0, "", "Cluster does not exist" except Exception as e: return exception_handler(e, f"Failed to delete NFS Cluster {cluster_id}") -- 2.47.3