From 9a558c51dc811d973aaf1c39df08dd61a316c0a0 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Mon, 2 Apr 2018 08:05:53 -0700 Subject: [PATCH] vstart_runner: examine check_status before error Issue found by Rishabh Dave. Fix suggested by John Spray. Signed-off-by: Patrick Donnelly --- qa/tasks/vstart_runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py index 62ac2921dea..15428080f0d 100644 --- a/qa/tasks/vstart_runner.py +++ b/qa/tasks/vstart_runner.py @@ -155,7 +155,7 @@ class LocalRemoteProcess(object): if self.finished: # Avoid calling communicate() on a dead process because it'll # give you stick about std* already being closed - if self.exitstatus != 0: + if self.check_status and self.exitstatus != 0: raise CommandFailedError(self.args, self.exitstatus) else: return -- 2.39.5