From 9b1a4bd08e65973f417ef65b282f8c4ddb9be237 Mon Sep 17 00:00:00 2001 From: Dave Chinner Date: Tue, 8 Apr 2008 06:20:04 +0000 Subject: [PATCH] xfsqa 185 shouldn't have uninitialised variables in the golden output Kill the output of uninitialised values when punching a hole. This prevents the test from passing on just about everything. Merge of master-melb:xfs-cmds:30762a by kenmcd. remove roffp and rlenp output for punch operations. --- 185.out | 5 ----- dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/185.out b/185.out index fa746d34..9fdbfca2 100644 --- a/185.out +++ b/185.out @@ -12,7 +12,6 @@ roffp is 0, rlenp is 16384 Method: dmapi_punch Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings: offset = '0', length = '16384', sid = '0' -roffp is 4200149, rlenp is 47820330485640 ======================================================= ======================================================= Testing with length = 1k, offset = 0 @@ -27,7 +26,6 @@ roffp is 0, rlenp is 1024 Method: dmapi_punch Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings: offset = '0', length = '1024', sid = '0' -roffp is 4200149, rlenp is 47194545715080 ======================================================= ======================================================= Testing with length = 1k, offset = 4k @@ -42,7 +40,6 @@ roffp is 4096, rlenp is 1024 Method: dmapi_punch Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings: offset = '4096', length = '1024', sid = '0' -roffp is 4200149, rlenp is 47256598480776 ======================================================= ======================================================= Testing with length = 4k, offset = 1k @@ -57,7 +54,6 @@ roffp is 1024, rlenp is 4096 Method: dmapi_punch Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings: offset = '1024', length = '4096', sid = '0' -roffp is 4200149, rlenp is 47292581427080 ======================================================= ======================================================= Testing with length = 1024k, offset = 512k @@ -72,5 +68,4 @@ roffp is 524288, rlenp is 1048576 Method: dmapi_punch Running DMAPI punch hole on /mnt/scratch/dmapi/holly_file with settings: offset = '524288', length = '1048576', sid = '0' -roffp is 4200149, rlenp is 47016592795528 ======================================================= diff --git a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c index 50fc7f4b..effa98a4 100644 --- a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c +++ b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c @@ -176,6 +176,7 @@ main( strerror(errno)); exit(1); } + fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp); break; case METHOD_DMAPI_PUNCH: if (dm_punch_hole(sid, hanp, hlen, DM_NO_TOKEN, offset, length)) { @@ -185,7 +186,6 @@ main( } break; } - fprintf(stdout, "roffp is %lld, rlenp is %lld\n", roffp, rlenp); dm_handle_free(hanp, hlen); return 0; -- 2.47.3