From 9b7f704ca31a3324b685749f7a733ca2111f0db8 Mon Sep 17 00:00:00 2001 From: Brian Foster Date: Thu, 15 May 2014 11:37:55 +1000 Subject: [PATCH] config: make sure tests check for loop device support Several tests happen to make use of loop device support without the requisite pre-test checks. This results in spurious failures for systems that might not have loop device support. Add _require_loop checks to shared/298, xfs/206 and xfs/259. Signed-off-by: Brian Foster Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner --- tests/shared/298 | 1 + tests/xfs/206 | 1 + tests/xfs/259 | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/shared/298 b/tests/shared/298 index f13c14b3..8211da39 100755 --- a/tests/shared/298 +++ b/tests/shared/298 @@ -32,6 +32,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fs ext4 xfs _supported_os Linux +_require_loop _require_fstrim _require_xfs_io_command "fiemap" _require_fs_space $TEST_DIR 307200 diff --git a/tests/xfs/206 b/tests/xfs/206 index 0bbd5953..f739597f 100755 --- a/tests/xfs/206 +++ b/tests/xfs/206 @@ -53,6 +53,7 @@ _cleanup() # Modify as appropriate. _supported_fs xfs _supported_os IRIX Linux +_require_loop bitsperlong=`src/feature -w` if [ "$bitsperlong" -ne 64 ]; then diff --git a/tests/xfs/259 b/tests/xfs/259 index b8bd69a2..8241d94d 100755 --- a/tests/xfs/259 +++ b/tests/xfs/259 @@ -41,7 +41,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_fs xfs _supported_os Linux - +_require_loop _require_math testfile=$TEST_DIR/259.image -- 2.47.3