From 9bf16b6c31d97b868d4bc591304152e4194dad80 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 10 Oct 2018 18:18:03 +0800 Subject: [PATCH] cmake: do not use plain target_link_libraries(rgw_a ...) this addresses following error: CMake Error at src/rgw/CMakeLists.txt:178 (target_link_libraries): The plain signature for target_link_libraries has already been used with the target "rgw_a". All uses of target_link_libraries with a target must be either all-keyword or all-plain. The uses of the plain signature are here: * src/rgw/CMakeLists.txt:168 (target_link_libraries) Signed-off-by: Kefu Chai --- src/rgw/CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/rgw/CMakeLists.txt b/src/rgw/CMakeLists.txt index 6239260ba696e..31efc05b8b547 100644 --- a/src/rgw/CMakeLists.txt +++ b/src/rgw/CMakeLists.txt @@ -165,7 +165,8 @@ add_dependencies(rgw_a civetweb_h) target_include_directories(rgw_a SYSTEM PUBLIC "../rapidjson/include") -target_link_libraries(rgw_a librados cls_otp_client cls_lock_client cls_rgw_client cls_refcount_client +target_link_libraries(rgw_a PRIVATE + librados cls_otp_client cls_lock_client cls_rgw_client cls_refcount_client cls_log_client cls_timeindex_client cls_version_client cls_user_client ceph-common common_utf8 global ${CURL_LIBRARIES} @@ -178,9 +179,9 @@ if(WITH_CURL_OPENSSL) target_link_libraries(rgw_a PRIVATE OpenSSL::Crypto) endif() -if (WITH_RADOSGW_BEAST_FRONTEND) +if(WITH_RADOSGW_BEAST_FRONTEND) target_compile_definitions(rgw_a PUBLIC BOOST_COROUTINES_NO_DEPRECATION_WARNING) - target_link_libraries(rgw_a Boost::coroutine Boost::context) + target_link_libraries(rgw_a PRIVATE Boost::coroutine Boost::context) endif() set(radosgw_srcs -- 2.39.5