From 9c720b748143c851889f4b2f3fd0509facf5a99d Mon Sep 17 00:00:00 2001 From: deepssin Date: Thu, 24 Jul 2025 06:28:40 -0400 Subject: [PATCH] [Openstack]allow all TCP ingress to prevent node communication failures Signed-off-by: deepssin --- teuthology/openstack/__init__.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/teuthology/openstack/__init__.py b/teuthology/openstack/__init__.py index 1fb5481917..c09e07525f 100644 --- a/teuthology/openstack/__init__.py +++ b/teuthology/openstack/__init__.py @@ -1222,15 +1222,15 @@ ssh access : ssh {identity}{username}@{ip} # logs in /usr/share/nginx/ server_sg = conn.network.create_security_group(name=self.server_group()) if not worker_sg: worker_sg = conn.network.create_security_group(name=self.worker_group()) - def add_rule(sg_id, protocol, port, remote_group_id=None): + def add_rule(sg_id, protocol, port=None, remote_group_id=None): rule_args = { 'security_group_id': sg_id, 'direction': 'ingress', 'protocol': protocol, - 'port_range_min': port, - 'port_range_max': port, 'ethertype': 'IPv4', } + if port is not None: + rule_args['port_range_min'] = rule_args['port_range_max'] = port if remote_group_id: rule_args['remote_group_id'] = remote_group_id else: @@ -1239,17 +1239,17 @@ ssh access : ssh {identity}{username}@{ip} # logs in /usr/share/nginx/ conn.network.create_security_group_rule(**rule_args) except Exception as e: log.warning(f"Security group rule creation skipped or failed: {e}") - # Rules for SSH, log, pulpito and paddles - for port in (22, 80, 8080, 8081): - add_rule(server_sg.id, 'tcp', port) + # tcp access to enable reliable inter-node communication + for sg in (server_sg, worker_sg): + add_rule(sg.id, 'tcp') # access between teuthology and workers for port in (65535,): - add_rule(worker_sg.id, 'udp', port, remote_group_id=server_sg.id) - add_rule(server_sg.id, 'udp', port, remote_group_id=worker_sg.id) + add_rule(worker_sg.id, 'udp', port=port, remote_group_id=server_sg.id) + add_rule(server_sg.id, 'udp', port=port, remote_group_id=worker_sg.id) # access between members of one group - add_rule(server_sg.id, 'udp', 65535, remote_group_id=server_sg.id) + add_rule(server_sg.id, 'udp', port=65535, remote_group_id=server_sg.id) # access within worker group - add_rule(worker_sg.id, 'udp', 65535, remote_group_id=worker_sg.id) + add_rule(worker_sg.id, 'udp', port=65535, remote_group_id=worker_sg.id) @staticmethod def get_unassociated_floating_ip(): -- 2.39.5