From 9ca45bd942ef1ed0d7ed61d87caffdfc97e54e5e Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 2 Apr 2020 13:29:45 +0800 Subject: [PATCH] qa/tasks: do not random.choice(a_view) use `random.sample()` instead of `random.choice(list(a_view))` for better performance. Signed-off-by: Kefu Chai --- qa/tasks/ceph_manager.py | 2 +- qa/tasks/cephfs/test_dump_tree.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qa/tasks/ceph_manager.py b/qa/tasks/ceph_manager.py index 3d41c2e3f482c..1ec5840d77bbb 100644 --- a/qa/tasks/ceph_manager.py +++ b/qa/tasks/ceph_manager.py @@ -1965,7 +1965,7 @@ class CephManager: """ with self.lock: if self.pools: - return random.choice(self.pools.keys()) + return random.sample(self.pools.keys(), 1)[0] def get_pool_pg_num(self, pool_name): """ diff --git a/qa/tasks/cephfs/test_dump_tree.py b/qa/tasks/cephfs/test_dump_tree.py index 6d943f9dd2ff3..48a2c6f00acb5 100644 --- a/qa/tasks/cephfs/test_dump_tree.py +++ b/qa/tasks/cephfs/test_dump_tree.py @@ -39,7 +39,7 @@ class TestDumpTree(CephFSTestCase): self.populate() inos = self.get_paths_to_ino() - target = random.choice(inos.keys()) + target = random.sample(inos.keys(), 1)[0] if target != "./": target = os.path.dirname(target) -- 2.39.5