From 9d43806df9fe44496dd48c2b7d3bef2e59d92365 Mon Sep 17 00:00:00 2001
From: Neha Ojha <nojha@redhat.com>
Date: Fri, 3 Aug 2018 20:08:31 +0000
Subject: [PATCH] infrastructure-playbooks: standardize variable usage with a
 space after brackets

Signed-off-by: Neha Ojha <nojha@redhat.com>
---
 infrastructure-playbooks/lv-create.yml   | 30 ++++++++++++------------
 infrastructure-playbooks/lv-teardown.yml | 16 ++++++-------
 2 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/infrastructure-playbooks/lv-create.yml b/infrastructure-playbooks/lv-create.yml
index ab96317a5..9d5e64096 100644
--- a/infrastructure-playbooks/lv-create.yml
+++ b/infrastructure-playbooks/lv-create.yml
@@ -18,34 +18,34 @@
   - name: add nvme device as lvm pv
     lvg:
       force: yes
-      pvs: "{{nvme_device}}"
+      pvs: "{{ nvme_device }}"
       pesize: 4
       state: present
-      vg: "{{nvme_vg_name}}"
+      vg: "{{ nvme_vg_name }}"
 
   - name: create lvs for fs journals for the bucket index on the nvme device
     lvol:
-      lv: "{{item.journal_name}}"
-      vg: "{{nvme_vg_name}}"
-      size: "{{journal_size}}"
-      pvs: "{{nvme_device}}"
+      lv: "{{ item.journal_name }}"
+      vg: "{{ nvme_vg_name }}"
+      size: "{{ journal_size }}"
+      pvs: "{{ nvme_device }}"
     with_items:
       - "{{ nvme_device_lvs }}"
 
   - name: create lvs for fs journals for hdd devices
     lvol:
       lv: "{{ hdd_journal_prefix }}-{{ item.split('/')[-1] }}"
-      vg: "{{nvme_vg_name}}"
-      size: "{{journal_size}}"
+      vg: "{{ nvme_vg_name }}"
+      size: "{{ journal_size }}"
     with_items:
       - "{{ hdd_devices }}"
 
   - name: create the lv for data portion of the bucket index on the nvme device
     lvol:
-      lv: "{{item.lv_name}}"
-      vg: "{{nvme_vg_name}}"
-      size: "{{item.size}}"
-      pvs: "{{nvme_device}}"
+      lv: "{{ item.lv_name }}"
+      vg: "{{ nvme_vg_name }}"
+      size: "{{ item.size }}"
+      pvs: "{{ nvme_device }}"
     with_items:
       - "{{ nvme_device_lvs }}"
 
@@ -53,7 +53,7 @@
   - name: create vgs for all hdd devices
     lvg:
       force: yes
-      pvs: "{{item}}"
+      pvs: "{{ item }}"
       pesize: 4
       state: present
       vg: "{{ hdd_vg_prefix }}-{{ item.split('/')[-1] }}"
@@ -63,8 +63,8 @@
   - name: create lvs for the data portion on hdd devices
     lvol:
       lv: "{{ hdd_lv_prefix }}-{{ item.split('/')[-1] }}"
-      vg: "{{hdd_vg_prefix}}-{{ item.split('/')[-1] }}"
-      size: "{{hdd_lv_size}}"
+      vg: "{{ hdd_vg_prefix }}-{{ item.split('/')[-1] }}"
+      size: "{{ hdd_lv_size }}"
       pvs: "{{ item }}"
     with_items:
       - "{{ hdd_devices }}"
diff --git a/infrastructure-playbooks/lv-teardown.yml b/infrastructure-playbooks/lv-teardown.yml
index 6b22aea1b..183d284d4 100644
--- a/infrastructure-playbooks/lv-teardown.yml
+++ b/infrastructure-playbooks/lv-teardown.yml
@@ -44,8 +44,8 @@
   ## Logcal Vols
   - name: tear down existing lv for bucket index
     lvol:
-      lv: "{{item.lv_name}}"
-      vg: "{{nvme_vg_name}}"
+      lv: "{{ item.lv_name }}"
+      vg: "{{ nvme_vg_name }}"
       state: absent
       force: yes
     with_items:
@@ -54,7 +54,7 @@
   - name: tear down any existing hdd data lvs 
     lvol:
       lv: "{{ hdd_lv_prefix }}-{{ item.split('/')[-1] }}"
-      vg: "{{hdd_vg_prefix}}-{{ item.split('/')[-1] }}"
+      vg: "{{ hdd_vg_prefix }}-{{ item.split('/')[-1] }}"
       state: absent
       force: yes
     with_items:
@@ -62,8 +62,8 @@
 
   - name: tear down any existing lv of journal for bucket index
     lvol:
-      lv: "{{item.journal_name}}"
-      vg: "{{nvme_vg_name}}"
+      lv: "{{ item.journal_name }}"
+      vg: "{{ nvme_vg_name }}"
       state: absent
       force: yes
     with_items:
@@ -72,7 +72,7 @@
   - name: tear down any existing lvs of hdd journals
     lvol:
       lv: "{{ hdd_journal_prefix }}-{{ item.split('/')[-1] }}"
-      vg: "{{nvme_vg_name}}"
+      vg: "{{ nvme_vg_name }}"
       state: absent
       force: yes
     with_items:
@@ -81,13 +81,13 @@
   ## Volume Groups
   - name: remove vg on nvme device
     lvg:
-      vg: "{{nvme_vg_name}}"
+      vg: "{{ nvme_vg_name }}"
       state: absent
       force: yes
 
   - name: remove vg for each hdd device
     lvg:
-      vg: "{{hdd_vg_prefix}}-{{ item.split('/')[-1] }}"
+      vg: "{{ hdd_vg_prefix }}-{{ item.split('/')[-1] }}"
       state: absent
       force: yes
     with_items:
-- 
2.39.5