From 9f4a6f65e4c59ca74ac7737440a93364a654e6e3 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 25 Jun 2021 11:11:35 -0400 Subject: [PATCH] crush: remove find_rule() Signed-off-by: Sage Weil --- src/crush/CrushWrapper.h | 13 ------------- src/crush/mapper.c | 22 ---------------------- src/crush/mapper.h | 1 - 3 files changed, 36 deletions(-) diff --git a/src/crush/CrushWrapper.h b/src/crush/CrushWrapper.h index d33d4bcf445dd..30e278a6404c7 100644 --- a/src/crush/CrushWrapper.h +++ b/src/crush/CrushWrapper.h @@ -1402,19 +1402,6 @@ public: crush->max_devices = m; } - int find_rule(int ruleset, int type, int size) const { - if (!crush) return -1; - if (have_uniform_rules && - ruleset < (int)crush->max_rules && - crush->rules[ruleset] && - crush->rules[ruleset]->mask.type == type && - crush->rules[ruleset]->mask.min_size <= size && - crush->rules[ruleset]->mask.max_size >= size) { - return ruleset; - } - return crush_find_rule(crush, ruleset, type, size); - } - bool ruleset_exists(const int ruleset) const { for (size_t i = 0; i < crush->max_rules; ++i) { if (rule_exists(i) && crush->rules[i]->mask.ruleset == ruleset) { diff --git a/src/crush/mapper.c b/src/crush/mapper.c index 4ac57262716a5..736cc6162c974 100644 --- a/src/crush/mapper.c +++ b/src/crush/mapper.c @@ -31,28 +31,6 @@ * Implement the core CRUSH mapping algorithm. */ -/** - * crush_find_rule - find a crush_rule id for a given ruleset, type, and size. - * @map: the crush_map - * @ruleset: the storage ruleset id (user defined) - * @type: storage ruleset type (user defined) - * @size: output set size - */ -int crush_find_rule(const struct crush_map *map, int ruleset, int type, int size) -{ - __u32 i; - - for (i = 0; i < map->max_rules; i++) { - if (map->rules[i] && - map->rules[i]->mask.ruleset == ruleset && - map->rules[i]->mask.type == type && - map->rules[i]->mask.min_size <= size && - map->rules[i]->mask.max_size >= size) - return i; - } - return -1; -} - /* * bucket choose methods * diff --git a/src/crush/mapper.h b/src/crush/mapper.h index 2332d4b511f28..0ec927d9e6162 100644 --- a/src/crush/mapper.h +++ b/src/crush/mapper.h @@ -10,7 +10,6 @@ #include "crush.h" -extern int crush_find_rule(const struct crush_map *map, int ruleset, int type, int size); /** @ingroup API * * Map __x__ to __result_max__ items and store them in the __result__ -- 2.39.5