From 9f6ee01e8d2e654452eb59be2e8372c99d8331c0 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Tue, 25 Sep 2012 16:07:23 -0700 Subject: [PATCH] JournalingObjectStore: lock journal_lock at top of journal_replay CID 716968: Data race condition (MISSING_LOCK)At (6): Accessing "this->op_seq" ("JournalingObjectStore.op_seq") requires the "Mutex._m" lock. Doesn't really matter, but this should satisfy coverity. Signed-off-by: Samuel Just --- src/os/JournalingObjectStore.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/os/JournalingObjectStore.cc b/src/os/JournalingObjectStore.cc index 2119f9538cf80..83864fc00cc52 100644 --- a/src/os/JournalingObjectStore.cc +++ b/src/os/JournalingObjectStore.cc @@ -37,10 +37,12 @@ int JournalingObjectStore::journal_replay(uint64_t fs_op_seq) fs_op_seq = g_conf->journal_replay_from - 1; } + journal_lock.Lock(); op_seq = fs_op_seq; committed_seq = fs_op_seq; committing_seq = fs_op_seq; applied_seq = fs_op_seq; + journal_lock.Unlock(); if (!journal) return 0; -- 2.39.5