From a0e86c05bdf5a4b2814e7b7cb1fb8736686e5478 Mon Sep 17 00:00:00 2001
From: Zack Cerza <zack@cerza.org>
Date: Thu, 29 Aug 2013 13:35:52 -0500
Subject: [PATCH] Move logging setup out of main()

---
 teuthology/run.py | 42 ++++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 18 deletions(-)

diff --git a/teuthology/run.py b/teuthology/run.py
index 5698a5660f13b..5ac0eaa796c3e 100644
--- a/teuthology/run.py
+++ b/teuthology/run.py
@@ -3,6 +3,7 @@ import os
 import yaml
 import StringIO
 import contextlib
+import logging
 
 def config_file(string):
     config = {}
@@ -82,40 +83,28 @@ def parse_args():
     args = parser.parse_args()
     return args
 
-def main():
-    from gevent import monkey; monkey.patch_all(dns=False)
-    from .orchestra import monkey; monkey.patch_all()
-
-    import logging
-
-    log = logging.getLogger(__name__)
-    ctx = parse_args()
 
+def set_up_logging(ctx):
     loglevel = logging.INFO
     if ctx.verbose:
         loglevel = logging.DEBUG
 
-    logging.basicConfig(
-        level=loglevel,
-        )
-
-    if ctx.owner is None:
-        from teuthology.misc import get_user
-        ctx.owner = get_user()
-
+    logging.basicConfig(level=loglevel)
     if ctx.archive is not None:
         os.mkdir(ctx.archive)
 
         handler = logging.FileHandler(
             filename=os.path.join(ctx.archive, 'teuthology.log'),
-            )
+        )
         formatter = logging.Formatter(
             fmt='%(asctime)s.%(msecs)03d %(levelname)s:%(name)s:%(message)s',
             datefmt='%Y-%m-%dT%H:%M:%S',
-            )
+        )
         handler.setFormatter(formatter)
         logging.getLogger().addHandler(handler)
 
+def write_initial_metadata(ctx):
+    if ctx.archive is not None:
         with file(os.path.join(ctx.archive, 'pid'), 'w') as f:
             f.write('%d' % os.getpid())
 
@@ -125,6 +114,23 @@ def main():
         with file(os.path.join(ctx.archive, 'orig.config.yaml'), 'w') as f:
             yaml.safe_dump(ctx.config, f, default_flow_style=False)
 
+
+def main():
+    from gevent import monkey
+    monkey.patch_all(dns=False)
+    from .orchestra import monkey
+    monkey.patch_all()
+
+    ctx = parse_args()
+    set_up_logging(ctx)
+    log = logging.getLogger(__name__)
+
+    if ctx.owner is None:
+        from teuthology.misc import get_user
+        ctx.owner = get_user()
+
+    write_initial_metadata(ctx)
+
     log.debug('test')
     raise RuntimeError('hi there')
 
-- 
2.39.5