From a0efff116cd038b08c0ce31a5c32c4b9df574088 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Thu, 10 Oct 2024 16:22:28 +0000 Subject: [PATCH] crimson: clarify ops_executer.h comment Signed-off-by: Samuel Just --- src/crimson/osd/ops_executer.h | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/crimson/osd/ops_executer.h b/src/crimson/osd/ops_executer.h index 6986f49ea08a7..3a7aaef7cd036 100644 --- a/src/crimson/osd/ops_executer.h +++ b/src/crimson/osd/ops_executer.h @@ -170,13 +170,9 @@ public: object_stat_sum_t delta_stats; private: - // an operation can be divided into two stages: main and effect-exposing - // one. The former is performed immediately on call to `do_osd_op()` while - // the later on `submit_changes()` – after successfully processing main - // stages of all involved operations. When any stage fails, none of all - // scheduled effect-exposing stages will be executed. - // when operation requires this division, some variant of `with_effect()` - // should be used. + // with_effect can be used to schedule operations to be performed + // at commit time. effects will be discarded if the operation does + // not commit. struct effect_t { // an effect can affect PG, i.e. create a watch timeout virtual seastar::future<> execute(Ref pg) = 0; -- 2.39.5