From a0f65a161aa84cea20f16fff94fb496e304c14c9 Mon Sep 17 00:00:00 2001 From: Joao Eduardo Luis Date: Wed, 17 Oct 2012 17:14:19 +0100 Subject: [PATCH] mon: MonitorStore: check return value of 'rename' for errors CID 716854: Unchecked return value (CHECKED_RETURN) At (10): Calling function "rename(tfn, fn)" without checking return value. Signed-off-by: Joao Eduardo Luis --- src/mon/MonitorStore.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mon/MonitorStore.cc b/src/mon/MonitorStore.cc index 2f14c2ef390bd..8806ad0d6a459 100644 --- a/src/mon/MonitorStore.cc +++ b/src/mon/MonitorStore.cc @@ -370,7 +370,13 @@ int MonitorStore::write_bl_ss_impl(bufferlist& bl, const char *a, const char *b, ::fsync(fd); ::close(fd); if (!append && !err) { - ::rename(tfn, fn); + int r = ::rename(tfn, fn); + if (r < 0) { + err = -errno; + derr << __func__ << " failed to rename '" << tfn << "' -> '" + << fn << "': " << cpp_strerror(err) << dendl; + return err; + } } return err; -- 2.39.5