From a13ae372c0729a25c35a7a17bc98ac732f511aaf Mon Sep 17 00:00:00 2001 From: Sam Lang Date: Mon, 18 Mar 2013 14:40:48 -0500 Subject: [PATCH] client: Remove unecessary set_inode() in _rmdir() With the recent changes in fc80c1dc6ee315ae5e039986602ffadba46cb43b, we only allow setting the inode once on a MetaRequest. This triggered a bug in _rmdir(), where the parent dir inode passed in and being set on the MetaRequest, and then also setting the dir inode on the MetaRequest. Removing the set_inode() using the parent dir inode resolves this issue. Signed-off-by: Sam Lang Reviewed-by: Sage Weil --- src/client/Client.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 08330e15b84c0..22f4a8b76db34 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -7248,7 +7248,6 @@ int Client::_rmdir(Inode *dir, const char *name, int uid, int gid) req->dentry_drop = CEPH_CAP_FILE_SHARED; req->dentry_unless = CEPH_CAP_FILE_EXCL; req->inode_drop = CEPH_CAP_LINK_SHARED | CEPH_CAP_LINK_EXCL; - req->set_inode(dir); Dentry *de; int res = get_or_create(dir, name, &de); -- 2.39.5