From a1b0c4fa7a4356ced67c4c1de1a49a2b8afe8106 Mon Sep 17 00:00:00 2001 From: Adam King Date: Mon, 22 Sep 2025 17:05:07 -0400 Subject: [PATCH] pybind/mgr: pin cheroot version in requirements-required.txt With python 3.10 (didn't seem to happen with python 3.12) the pybind/mgr/cephadm/tests/test_node_proxy.py test times out. This appears to be related to a new release of the cheroot package and a github issues describing the same problem we're seeing has been opened by another user https://github.com/cherrypy/cheroot/issues/769 It is worth noting that the workaround described in that issue does also work for us. If you add ``` import cheroot cheroot.server.HTTPServer._serve_unservicable = lambda: None ``` after the existing imports in test_node_proxy.py the test hanging issue also disappears. Also worth noting the particular pin of cheroot~=10.0 was chosen as it matches the existing pin being used in pybind/mgr/dashboard/constraints.txt Signed-off-by: Adam King (cherry picked from commit 6231955b5d00ae6b3630ee94e85b2449092ef0fe) --- src/pybind/mgr/requirements-required.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pybind/mgr/requirements-required.txt b/src/pybind/mgr/requirements-required.txt index 76fef65dbe4..7e4628f4d0e 100644 --- a/src/pybind/mgr/requirements-required.txt +++ b/src/pybind/mgr/requirements-required.txt @@ -16,3 +16,4 @@ setuptools werkzeug natsort bcrypt +cheroot~=10.0 -- 2.39.5