From a2006507a08b3182820bfb1fccabaa81615b6083 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Sat, 7 Dec 2013 13:19:49 -0800 Subject: [PATCH] PGLog: don't move up log.tail Moving up log.tail unnecessarily risks backfilling a replica after a split. Also, it disrupts the property that replicas from the most recent interval which performed writes must have overlapping logs. Signed-off-by: Samuel Just --- src/osd/PGLog.cc | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/osd/PGLog.cc b/src/osd/PGLog.cc index 9f6ca1f70c3bc..f9a6b97b94d05 100644 --- a/src/osd/PGLog.cc +++ b/src/osd/PGLog.cc @@ -40,22 +40,12 @@ void PGLog::IndexedLog::split_into( ) { if ((i->soid.hash & mask) == child_pgid.m_seed) { olog->log.push_back(*i); - if (log.empty()) - tail = i->version; } else { log.push_back(*i); - if (olog->empty()) - olog->tail = i->version; } oldlog.erase(i++); } - if (log.empty()) - tail = head; - - if (olog->empty()) - olog->tail = olog->head; - olog->index(); index(); } -- 2.39.5