From a2d3f9bb63998da12827409adeb5b090486a6a69 Mon Sep 17 00:00:00 2001 From: Ronen Friedman Date: Thu, 5 Nov 2020 10:38:37 +0200 Subject: [PATCH] librbd: removing a "pessimizing move" Silencing a compiler warning ("warning: moving a temporary object prevents copy elision") Signed-off-by: Ronen Friedman --- src/librbd/cache/ObjectCacherObjectDispatch.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/librbd/cache/ObjectCacherObjectDispatch.cc b/src/librbd/cache/ObjectCacherObjectDispatch.cc index 2fefb26af73b1..81d5a71885b01 100644 --- a/src/librbd/cache/ObjectCacherObjectDispatch.cc +++ b/src/librbd/cache/ObjectCacherObjectDispatch.cc @@ -326,9 +326,9 @@ bool ObjectCacherObjectDispatch::write( SnapContext snapc; if (io_context->write_snap_context()) { auto write_snap_context = *io_context->write_snap_context(); - snapc = std::move(SnapContext(write_snap_context.first, - {write_snap_context.second.begin(), - write_snap_context.second.end()})); + snapc = SnapContext(write_snap_context.first, + {write_snap_context.second.begin(), + write_snap_context.second.end()}); } m_image_ctx->image_lock.lock_shared(); -- 2.39.5