From a3970e56269a26016b99aed53af045df45a01109 Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Wed, 13 Feb 2013 13:14:02 +0100 Subject: [PATCH] CephxProtocol.h: pass CryptoKey by reference to decode_decrypt() Fix issues found by cppcheck: [src/auth/cephx/CephxProtocol.h:469]: (performance) Function parameter 'key' should be passed by reference. Pass CryptoKey by reference as already done in encode_encrypt(). Signed-off-by: Danny Al-Gaaf --- src/auth/cephx/CephxProtocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/auth/cephx/CephxProtocol.h b/src/auth/cephx/CephxProtocol.h index 38e0616b501ed..9386a410f95d8 100644 --- a/src/auth/cephx/CephxProtocol.h +++ b/src/auth/cephx/CephxProtocol.h @@ -466,7 +466,7 @@ void encode_encrypt_enc_bl(CephContext *cct, const T& t, const CryptoKey& key, } template -int decode_decrypt(CephContext *cct, T& t, const CryptoKey key, +int decode_decrypt(CephContext *cct, T& t, const CryptoKey& key, bufferlist::iterator& iter, std::string &error) { bufferlist bl_enc; -- 2.39.5