From a7e86a0d4463e5c1d4b614d7596df99eed4e42c5 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 6 Mar 2021 15:43:33 +0800 Subject: [PATCH] cmake: make the linkage to pmem::pmemobj public tools/ceph-dencoder/rbd_types.cc includes Types.h which in turn includes libpmemobj.h via librbd/cache/pwl/Types.h. and ceph-dencoder pulls in the rbd_type.cc's linked libraries by linking against rbd_types. but before this change, rbd_types links against pmem::pmemobj as a PRIVATE library. so, if we want to pull in rbd_types linkage we should always link rbd_types as a PUBLIC library. as rbd_types include libpmemobj.h in its header file. Signed-off-by: Kefu Chai --- src/librbd/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/librbd/CMakeLists.txt b/src/librbd/CMakeLists.txt index 0ba78390c8ad3..5fe0c55dfb276 100644 --- a/src/librbd/CMakeLists.txt +++ b/src/librbd/CMakeLists.txt @@ -18,7 +18,7 @@ add_library(rbd_types STATIC if (WITH_RBD_RWL) target_link_libraries(rbd_types - PRIVATE pmem::pmemobj) + PUBLIC pmem::pmemobj) endif() set(librbd_internal_srcs -- 2.39.5