From a8576fa783d23742ba9a117c66322aa4fdda788b Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Sat, 8 Feb 2025 15:03:32 -0500 Subject: [PATCH] container: stop deleting python generated files Stop deleting the python generated files (pyc, pyo) that RPM packages have installed. At some point in the misty past someone thought it would be a good idea to remove these. This practice got carried over to the new in-tree Containerfile. IMO this is probably due to a thought to save space, but if that's the case then the RPMs should not be carrying them either. Plus, not having them is going to slow python down as it needs to compile every py file that gets loaded. Let's be consistent: if the RPMs have pyc and pyo files then they should be in the image - if they're bad or too big they should not be in the RPMs either, right? This has the pleasant side effect of making `rpm -Va` inside the image happier. Fixes: https://tracker.ceph.com/issues/69869 Signed-off-by: John Mulligan (cherry picked from commit 0f178e61de52c6a0b757f8f6937340c002e66c73) --- container/Containerfile | 2 -- 1 file changed, 2 deletions(-) diff --git a/container/Containerfile b/container/Containerfile index 2ab00817a71..39dbf34a805 100644 --- a/container/Containerfile +++ b/container/Containerfile @@ -210,8 +210,6 @@ RUN set -ex && \ rm -f /var/lib/rpm/__db* && \ # remove unnecessary files with big impact rm -rf /etc/selinux /usr/share/selinux && \ - # don't keep compiled python binaries - find / -xdev \( -name "*.pyc" -o -name "*.pyo" \) -delete && \ rm -f /etc/yum.repos.d/{ceph,ganesha,tcmu-runner,ceph-iscsi}.repo # Verify that the packages installed haven't been accidentally cleaned, then -- 2.39.5