From a8b518917759ee2e031408e485d0161499208f03 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 14 Dec 2020 23:14:11 +0800 Subject: [PATCH] crimson/osd: use range-based for loop for better readability Signed-off-by: Kefu Chai --- src/crimson/osd/replicated_recovery_backend.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc index 9c46d9391a2..ded157df7ef 100644 --- a/src/crimson/osd/replicated_recovery_backend.cc +++ b/src/crimson/osd/replicated_recovery_backend.cc @@ -558,13 +558,9 @@ ReplicatedRecoveryBackend::get_shards_to_push(const hobject_t& soid) { std::list::const_iterator> shards; assert(pg.get_acting_recovery_backfill().size() > 0); - for (set::iterator i = - pg.get_acting_recovery_backfill().begin(); - i != pg.get_acting_recovery_backfill().end(); - ++i) { - if (*i == pg.get_pg_whoami()) + for (const auto& peer : pg.get_acting_recovery_backfill()) { + if (peer == pg.get_pg_whoami()) continue; - pg_shard_t peer = *i; map::const_iterator j = pg.get_shard_missing().find(peer); assert(j != pg.get_shard_missing().end()); -- 2.39.5