From aa34321a4a74f29ef1efa63b5561aa4918ca4fb8 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 27 Nov 2017 12:08:04 +0800 Subject: [PATCH] qa/workunits/ceph-disk: do not redirect stderr to stdout normally, if we care about the output of ceph-disk, we expect a json string, and ceph-disk sends the output to stdout, and errors/warnings to stderr. so everything works as expected. and the test should also follow this tradition. for example, if deprecated warnings are printed, the warning message should not be collected along with the json string. see also: d44334f3 Signed-off-by: Kefu Chai --- qa/workunits/ceph-disk/ceph-disk-test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/qa/workunits/ceph-disk/ceph-disk-test.py b/qa/workunits/ceph-disk/ceph-disk-test.py index efc080dc0ea..411cd77fe87 100644 --- a/qa/workunits/ceph-disk/ceph-disk-test.py +++ b/qa/workunits/ceph-disk/ceph-disk-test.py @@ -77,7 +77,6 @@ class CephDisk: proc = subprocess.Popen( args=command, stdout=subprocess.PIPE, - stderr=subprocess.STDOUT, shell=True, bufsize=1) output, _ = proc.communicate() -- 2.39.5